config: new interpolation function jsonencode #5890
Conversation
| `${jsonencode(hard)}`, | ||
| `" foo \\ \n \t \" bar "`, | ||
| false, | ||
| }, |
There was a problem hiding this comment.
Would you mind adding one more test case with an empty string to confirm that an error is returned in such cases?
There was a problem hiding this comment.
I can add a test case for the empty string, but why should it be an error rather than ""?
There was a problem hiding this comment.
I added a test case for the empty string (no error) and for no argument given (error).
There was a problem hiding this comment.
Empty string should remain empty string, naturally. 👍 I was more looking for any test covering the erroneous state.
|
Besides the test case w/ failure, this is looking good. It has other good test cases + documentation. 👍 |
radeksimko
added
the
waiting-response
radeksimko
removed
the
waiting-response
|
Thanks! |
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
ghost
locked and limited conversation to collaborators
We find ourselves wanting to construct JSON config files in (eg) S3 bucket objects based on the values of Terraform variables, so being able to JSON-encode strings safely is helpful.